workload: fix partition commands in tpcc import #40431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commands for partitioning indexes in the TPCC import were erroring out due to a syntax change introduced in cockroachdb#39332. I updated them to use `ALTER PARTITION ... OF INDEX` rather than `ALTER PARTITION ... OF TABLE`. Fixes cockroachdb#39005 Fixes cockroachdb#40360 Fixes cockroachdb#40416 Release note: None
|
This change is |
|
Where is the code that uses this change? |
|
It is used when loading data for the TPCC workload. See the cockroach/pkg/workload/tpcc/partition.go Line 405 in 92230f0 |
rohany
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rohany)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 3, 2019
40248: opt: calculate number of rows processed when costing joins r=rytaft a=rytaft This PR updates the costing of joins to take into account the number of rows processed by the operator. This number may be larger than the number of output rows if an additional filter is applied as part of the ON condition that is not used to determine equality columns for the join. For example, consider the query `SELECT * FROM abc JOIN def ON a = e AND b = 3;` Assuming there is no index on b, if a lookup join is used to execute this query, the number of rows processed is actually the same as the query `SELECT * FROM abc JOIN def ON a = e;` The difference is that the filter b=3 must also be applied to every row in the first query. The coster now takes this into account when determining the cost of joins. Fixes #34810 Release note: None 40431: workload: fix partition commands in tpcc import r=solongordon a=solongordon The commands for partitioning indexes in the TPCC import were erroring out due to a syntax change introduced in #39332. I updated them to use `ALTER PARTITION ... OF INDEX` rather than `ALTER PARTITION ... OF TABLE`. Fixes #39005 Fixes #40360 Fixes #40416 Release note: None Co-authored-by: Rebecca Taft <becca@cockroachlabs.com> Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commands for partitioning indexes in the TPCC import were erroring
out due to a syntax change introduced in #39332. I updated them to use
ALTER PARTITION ... OF INDEXrather thanALTER PARTITION ... OF TABLE.Fixes #39005
Fixes #40360
Fixes #40416
Release note: None